cesium-unreal icon indicating copy to clipboard operation
cesium-unreal copied to clipboard

Why is cesium-native set as url = ../cesium-native.git ?

Open installgentoo opened this issue 3 years ago • 4 comments

So why is the dependency set to relative path? This was a minor annoyance for me when i was trying to figure why isn't fetching submodules work by default. Should this be set to absolute instead?

installgentoo avatar Jul 11 '22 12:07 installgentoo

We do that so that cesium-native is fetched over either https or ssh, depending on which was used to fetch cesium-unreal. What problem did it cause for you?

kring avatar Jul 11 '22 14:07 kring

When i forked cesium-native to make pull requests, i had to manually change the path to cesium-native submodule. I suppose alternatively i could fork it too, but then i'd have to fetch it manually on my repo, all the time.

installgentoo avatar Jul 11 '22 23:07 installgentoo

Ok, I think we could fix that by changing the relative path to ../../CesiumGS/cesium-native.git. I'm happy to merge a pull request with that change if it works for you.

kring avatar Jul 13 '22 03:07 kring

Sure it does.

installgentoo avatar Jul 13 '22 03:07 installgentoo