cesium-unreal icon indicating copy to clipboard operation
cesium-unreal copied to clipboard

Add support for conan

Open baothientran opened this issue 4 years ago • 9 comments

This PR is used to accommodate the conan support PR for cesium-native

  • Instead of hardcode the absolute library name, I just check if the file paths in the third-party directory contains the library name. If it does, then we will use that lib path for unreal plugin. That is because in Conan, the name of the library is inconsistent. For example, tinyxml2 library can have the same name tinyxml2.lib for both debug and release build. However, spdlog can have spdlogd.lib for debug and spdlog.lib for release.
  • Remove the third-party directory whenever we do cmake install cesium-native. That prevents the above solution mixes debug and release build together
  • Add fmt lib to unreal since conan spdlog depends on it

TODO:

  • [ ] Fixes CI build to install conan

baothientran avatar Jun 04 '21 02:06 baothientran

Thanks for the pull request @baothientran!

  • :heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

cesium-concierge avatar Jun 04 '21 02:06 cesium-concierge

Thanks again for your contribution @baothientran!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Aug 17 '21 02:08 cesium-concierge

Thanks again for your contribution @baothientran!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Sep 16 '21 02:09 cesium-concierge

Thanks again for your contribution @baothientran!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Oct 16 '21 02:10 cesium-concierge

Thanks again for your contribution @baothientran!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Nov 15 '21 03:11 cesium-concierge

Thanks again for your contribution @baothientran!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Dec 15 '21 03:12 cesium-concierge

Thanks again for your contribution @baothientran!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Jan 14 '22 03:01 cesium-concierge

Thanks again for your contribution @baothientran!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Feb 13 '22 03:02 cesium-concierge

Thanks again for your contribution @baothientran!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge avatar Mar 15 '22 02:03 cesium-concierge

Closing this draft PR due to its age. (over 1 year of inactivity).

From discussions with @kring, integrating conan was fairly difficult due to timing between conan versions and due to the framework itself. Ultimately, robust dependency management is still needed for both this repo and cesium-native, whether we use the latest conan version, VCPKG, or some other solution.

csciguy8 avatar Jun 21 '23 22:06 csciguy8