cesium-unreal icon indicating copy to clipboard operation
cesium-unreal copied to clipboard

Update `CesiumRuntime.Build.cs` for Cesium Native changes

Open j9liu opened this issue 1 year ago • 3 comments

  • Updates for KTX library changes: ktx_read -> ktx
  • Adds new CesiumQuantizedMeshTerrain namespace

j9liu avatar Apr 25 '24 19:04 j9liu

Look like good changes to update cesium-native.

Seeing this weird CI error across all iOS versions... CMake Error at cesium-native/CMakeLists.txt:210 (install): install TARGETS given no FRAMEWORK DESTINATION for static library FRAMEWORK target "ktx".

Not obvious why this is occurring. Looking into it... (unless you beat me to it)

csciguy8 avatar Apr 26 '24 16:04 csciguy8

Earlier in the iOS CI logs, I see this warning as well. Not sure if it's related:

CMake Warning at cesium-native/extern/KTX-Software/cmake/version.cmake:151 (message): Error retrieving version from GIT tag. Falling back to 0.0.0-noversion Call Stack (most recent call first): cesium-native/extern/KTX-Software/CMakeLists.txt:13 (include)

j9liu avatar Apr 26 '24 19:04 j9liu

I think I have a fix for the iOS cmake errors.

Needed a cesium-native change, so I committed that update.

This PR now depends on cesium-native PR 869

csciguy8 avatar Apr 27 '24 15:04 csciguy8

@csciguy8 I was making some changes to sync with the new cesium-native changes before this was merged. I'm going to cancel your CI build and push them to main directly.

j9liu avatar Apr 29 '24 21:04 j9liu

Whoops! Go for it.

csciguy8 avatar Apr 29 '24 21:04 csciguy8