cesium-unity icon indicating copy to clipboard operation
cesium-unity copied to clipboard

Resolved bug

Open wjs123456 opened this issue 10 months ago • 9 comments

When offline terrain file not exist,cesium terrain mesh incomplete display

wjs123456 avatar Feb 28 '25 10:02 wjs123456

Hi @wjs123456, please provide more details about how to reproduce the problem you're seeing. Screenshots may help a lot!

kring avatar Mar 03 '25 06:03 kring

Hi @wjs123456, please provide more details about how to reproduce the problem you're seeing. Screenshots may help a lot!

截图 When Cesium Unity is loading offline terrain data and the local terrain data is missing at some levels, Unity's SendWebRequest will not return a completed status, which results in CesiumAsync::IAssetRequest having no way of knowing the tile acquisition status of the current level.

wjs123456 avatar Mar 03 '25 08:03 wjs123456

Sorry @wjs123456, I don't really follow you. You should avoid having missing tiles, right? And returning a "completed" status for a tile that doesn't exist seems wrong. So I don't what you're suggesting is wrong, what you're suggesting to change, or what that screenshot has to do with anything.

Please describe it in as much detail as you can. If English is not your first language, feel free to use your native language and we will translate it.

kring avatar Mar 04 '25 01:03 kring

Hi @wjs123456,

Could you please respond to Kevin's questions above? We'd like to triage this PR but without more information, we'll have to close it for inactivity.

j9liu avatar Mar 14 '25 14:03 j9liu

Closing due to inactivity. Feel free to reopen when you have more detail @wjs123456.

kring avatar Mar 19 '25 06:03 kring

I somehow missed that this is a PR, not an issue. So first of all, thank you for the PR @wjs123456! And second, I'm going to reopen it, because it's clear you're providing a solution to some problem, even if we don't completely understand what it is.

We still need your help to get this merged, though. If you haven't signed the Contributor License Agreement already, please do that so that we can review this: https://cesium.com/learn/cesium-native/ref-doc/contributing.html#md__2home_2runner_2work_2cesium-native_2cesium-native_2CONTRIBUTING

And we could also still use a bit more detail about what problem you ran into that this PR is meant to solve.

Thanks!

kring avatar Mar 19 '25 06:03 kring

Hi @wjs123456, we don't seem to have a signed CLA from you, and we can't review this without one. Because we haven't heard from you in awhile, I am going to close this PR. But if you're able to get back to this and sign the CLA, please feel free to reopen this pull request. We would definitely appreciate it.

kring avatar Apr 22 '25 06:04 kring

Hi @wjs123456, we don't seem to have a signed CLA from you, and we can't review this without one. Because we haven't heard from you in awhile, I am going to close this PR. But if you're able to get back to this and sign the CLA, please feel free to reopen this pull request. We would definitely appreciate it.

Sorry, I just noticed this information. I have signed the CLA. Please check it.

wjs123456 avatar May 08 '25 08:05 wjs123456

Thanks @wjs123456, I can confirm we received the signed CLA. I'll reopen this PR and we'll review it soon. In the meantime, any additional background or details you can provide would go a long way toward getting it accepted!

kring avatar May 08 '25 10:05 kring