cesium-o3de
cesium-o3de copied to clipboard
O3DE 22.10 Shader fixes
Workaround fixes for shader compilation for O3DE 22.10 / current development branch Extends upon https://github.com/CesiumGS/cesium-o3de/pull/45 Fixes https://github.com/CesiumGS/cesium-o3de/issues/47
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
The Cesium Gem uses the material->SetPropertyValue(...)
function in multiple places within https://github.com/lgleim/cesium-o3de/blob/main/Code/Source/Cesium/TilesetUtility/GltfRasterMaterialBuilder.cpp
Since the recent O3DE refactoring in https://github.com/o3de/o3de/commit/8d040facca379ad06ada1fcbeb09ddbcf9cdb19c the code fails to link with the following error thrown:
mold: error: undefined symbol: bool AZ::RPI::Material::SetPropertyValue<AZ::Data::Asset<AZ::RPI::ImageAsset> >(AZ::RHI::Handle<unsigned int, AZ::RPI::MaterialPropertyIndexType>, AZ::Data::Asset<AZ::RPI::ImageAsset> const&)
>>> referenced by GltfRasterMaterialBuilder.cpp
>>> lib/profile/libCesium.Static.a(GltfRasterMaterialBuilder.cpp.o):(Cesium::GltfRasterMaterialBuilder::UnsetRasterForMaterial(unsigned int, AZStd::intrusive_ptr<AZ::RPI::Material>&))
Before the commit, the corresponding function could be found here: https://github.com/o3de/o3de/blob/ddbb3da2eff4e741fa355dd9e6d0475deee3ef44/Gems/Atom/RPI/Code/Source/RPI.Public/Material/Material.cpp#L603 @santorac Since you have a much better overview of the ongoing refactoring work, could you advise on how best to resolve this issue? I will then address this issue in my PR.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.
Thanks again for your contribution @lgleim!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop
. If you want me to start again, just delete the comment.