Missing `ellipsoid` parameter

Open lilleyse opened this issue 1 year ago • 2 comments

An ellipsoid should get passed to BoundingRegion here:

https://github.com/CesiumGS/cesium-native/blob/31e93ac2992eeac7600357710dc50b7c70d54b85/Cesium3DTilesSelection/src/TilesetContentManager.cpp#L154-L157

Caught while compiling with CESIUM_DISABLE_DEFAULT_ELLIPSOID

Sep 30 '24 21:09 lilleyse

Good catch! I'll make a PR to fix this. Perhaps we should be building for CI with CESIUM_DISABLE_DEFAULT_ELLIPSOID to catch bugs like this?

Oct 01 '24 14:10 azrogers

Perhaps we should be building for CI with CESIUM_DISABLE_DEFAULT_ELLIPSOID to catch bugs like this?

I think that's a good idea.

Oct 01 '24 15:10 lilleyse

Closing since #956 was merged.

Nov 08 '24 15:11 j9liu