cesium-native icon indicating copy to clipboard operation
cesium-native copied to clipboard

Credits don't work when updates are suspended

Open kring opened this issue 2 years ago • 1 comments

Most of the cesium-native integrations have a "Suspend Update" feature. When enabled, they don't call Tileset::updateView, so the current set of loaded and selected tiles is frozen in place. This is useful for debugging.

But this doesn't work well with credits. If updateView isn't called in a frame, then none of that tileset's credits will be shown in that frame. The credits disappear, rather than being frozen like the tiles are.

One way to solve this is to move the "suspend update" feature into cesium-native, probably in TilesetOptions. Then the integrations would always call updateView, but when updates are suspended it would exit early without loading or selecting tiles. It would apply the previously-selected credits to the current frame, though, fixing this bug.

kring avatar May 04 '23 09:05 kring

I ran into this issue in Cesium for Omniverse yesterday as well.

lilleyse avatar May 04 '23 12:05 lilleyse

This seems to have been indirectly solved by #1125 and the credit system rework.

j9liu avatar Jul 09 '25 18:07 j9liu