cesium-native
cesium-native copied to clipboard
CesiumGS
Add dynamic screen space error
This PR experiments with dynamic screen space error that is implemented in CesiumJS [here] (https://github.com/CesiumGS/cesium/blob/a0c6ff34dff12ffede139e8978260cd9ba5c9d15/Source/Scene/Cesium3DTileset.js#L2208)
However, this deviates from the CesiumJS implementation a little bit. In the CesiumJS, it uses fog functions to control the sse based on distance between the camera and tile. The further the tile is away from camera, the more coarse the tile is going to get compared to its original sse. But the fog function doesn't allow the user to configure the near distance at which we want to apply dynamic SSE. This PR uses the Hermite interpolation or smoothstep() to do that. Also the fog function and hermite is quite pretty similar for x > 0. e.g https://www.desmos.com/calculator/bvcofnekxw
Also in CesiumJS, it automatically tries to configure the minimum height and max height of the root to apply dynamic SSE. Outside of that range, dynamic SSE will not apply. But that doesn't work for tileset that covers the whole earth, so I opt it to be a parameter to let the user set by themselves. The CesiumJS method can be implemented by client if desired though.
Once this dynamic SSE is something we should add, I can properly rework the PR. It's just the prototype quality currently though
Thanks again for your contribution @baothientran!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.
See the Unreal side of this, with more discussion: https://github.com/CesiumGS/cesium-unreal/pull/798
Thanks again for your contribution @baothientran!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.
Thanks again for your contribution @baothientran!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.
Thanks again for your contribution @baothientran!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.
Thanks again for your contribution @baothientran!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.
Thanks again for your contribution @baothientran!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.
Thanks again for your contribution @baothientran!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.
Thanks again for your contribution @baothientran!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.
Thanks again for your contribution @baothientran!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.