time-series-labs icon indicating copy to clipboard operation
time-series-labs copied to clipboard

Published 20 hours ago • verified publisher icon CertifaiAI

Jz fix seq2 seq

Open jingzhi93 opened this issue 4 years ago • 6 comments

jingzhi93 avatar Dec 28 '20 03:12 jingzhi93

Dear @evanyeohboonkhai your review is needed on this just a reminder Tq.

KianYang-Lee avatar Jan 21 '21 08:01 KianYang-Lee

Hi Team, I have added some modification to the seq2seq. Modification:

  • Some of the coding
  • Add instruction and description Please have a view of these.Thanks @scot-certifai @KianYang-Lee

evanyeohboonkhai avatar May 24 '21 07:05 evanyeohboonkhai

04 - Seq2Seq Basics

  1. the dunder function getitem allows the use of [], don't need to specify it in a function
  2. lack of description for "Model evaluation" and "Inverse transform"
  3. fix the plot
  4. add description to differentiate single step and multi-step
  5. fix multistep output

jingzhi93 avatar Jun 09 '21 04:06 jingzhi93

Fix both the basic and sunspot notebook, and update environment file for new add plotly library @jingzhi93, please have a view on this. Thanks

evanyeohboonkhai avatar Jul 01 '21 09:07 evanyeohboonkhai

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 08 '21 14:08 sonarqubecloud[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Aug 23 '21 04:08 review-notebook-app[bot]