Mazdak Farrokhzad

Results 185 comments of Mazdak Farrokhzad

This is essentially covered by #2584.

There's no ambiguity, you have to write `-> { old_value: Option, } { ... }`.

@RReverser My understanding is that the `Identity` type will still be a 32 byte value and in that case, this still makes it more efficient and more amenable to fast...

> This is now fully ready for merge together with [clockworklabs/SpacetimeDBPrivate#1060](https://github.com/clockworklabs/SpacetimeDBPrivate/pull/1060) @Centril PR looks good, but did you give any thought to the formatting changes of identity? I personally think...

> > PR looks good, but did you give any thought to the formatting changes of identity? I personally think they are an improvement, but ymmv. > > Ah, see...

> Please update the PR description to match the template. 👍 > * I would like to see a Rust SDK test added which verifies that it's possible to construct...

It's not high priority. It's easy to do (1h work) but not the biggest impact item for perf.

> although maybe the name should be `singleton` since it's a 1-tuple. The notion of a "singleton type" is already used for a type inhabited by a single value in...

It does not affect the BSATN of `AlgebraicValue` at all, but it does add a non-breaking change to the BSATN of `AlgebraicType` itself.