pythermalcomfort
pythermalcomfort copied to clipboard
CenterForTheBuiltEnvironment
replace _set with set
The "set" is a more intuitive variable name, and it also correspond to the one In the documentation
I agree that we should consider changing this, however, we need to think carefully on how to implement this since this is a breaking change.
I agree that we should consider changing this, however, we need to think carefully on how to implement this since this is a breaking change.
Can we update the document? Replacing the set with _set
@ruijis are you referring to update the documentation? I can do that but this will break old code, I will need to release a new major version of pythermalcomfort and explain the breaking change. I have some students currently working on the source code, maybe we can wait until they finish their work and then publish a new major version of pythermalcomfort which also includes this change. Do you need this to be done in a hurry?
@ruijis are you referring to update the documentation? I can do that but this will break old code, I will need to release a new major version of pythermalcomfort and explain the breaking change. I have some students currently working on the source code, maybe we can wait until they finish their work and then publish a new major version of pythermalcomfort which also includes this change. Do you need this to be done in a hurry?
Never mind, I thought changing the documentation would be easy. If there's a new major version coming out, we should continue using set and modify the code. Thank you, Fed.
We cannot only change the documentation since the output is called _set we will have to update both at the same time.
I have fixed this in version 3.0, I will publish this version soon