waterbutler icon indicating copy to clipboard operation
waterbutler copied to clipboard

[SVCS-904] Hf/fix gdoc renames

Open NyanHelsing opened this issue 5 years ago • 0 comments

Ticket

https://openscience.atlassian.net/browse/SVCS-904

Purpose

wb puts an extension on gdrive files so it can tell mfr how to render them, and to tell fangorn what icon to use. Because of this, when a file gets renamed, wb doesn't send a path that matches up with where the old on was on a rename, causing the osf to thing the second half of the rename to actually be a create. This change makes it so wb will send the actual name of the file on the storage provider, rather than modifying it. This change means osf finds the old file when it gets renamed, and the old file is modified to match the rename. rather than creating a new file_node.

As a side effect, mfr needs to be updated to not rely on the extension that wb used to suffix on the path. That PR is here: #352

Changes

Depends on mfr pr also https://github.com/CenterForOpenScience/modular-file-renderer/pull/352

Side effects

If multiple gdrive documents have the same name there may be some wierdness. Also

QA Notes

Deployment Notes

NyanHelsing avatar Sep 20 '18 20:09 NyanHelsing