waterbutler icon indicating copy to clipboard operation
waterbutler copied to clipboard

Published 20 hours ago • verified publisher icon CenterForOpenScience

[] [SVCS-694] Fix wb_path imports

Open NyanHelsing opened this issue 6 years ago • 2 comments

Ticket

https://openscience.atlassian.net/browse/SVCS-694

Purpose

Improve code consistency

Changes

wb_path is being imported qualified from wabterbutler.core.path. Most other files import the WaterButlerPath class directly. This change updates core/provider to align with other files.

Side effects

QA Notes

Deployment Notes

NyanHelsing avatar Apr 10 '18 17:04 NyanHelsing

Coverage Status

Coverage decreased (-0.01%) to 89.851% when pulling be645cc8f9279350aa864bddbb49d6d278f9880b on birdbrained:ft/wb-path-import-fix into 98b057cf5b00ca139326e759e52bffdde0517e6e on CenterForOpenScience:develop.

coveralls avatar Apr 10 '18 18:04 coveralls

Reviewing this now but meanwhile please remove this merge commit https://github.com/CenterForOpenScience/waterbutler/pull/334/commits/be645cc8f9279350aa864bddbb49d6d278f9880b and use rebase, thanks. @birdbrained

cslzchen avatar May 07 '18 21:05 cslzchen