waterbutler icon indicating copy to clipboard operation
waterbutler copied to clipboard

[SVCS-426] Update googledrive provider to use googledrive v3 API

Open TomBaxter opened this issue 6 years ago • 11 comments

Ticket

SVCS-426

Purpose

Update GoogleDrive provider to v3 of the GoogleDrive API

Changes

Substantial changes to all aspects of the provider.

Of particular note:

GD v3 API has no method of downloading GoogleDoc revisions. This PR leaves behind GD v2 calls, in order to maintain this functionality as long as possible.

GD v3 returns minimal representations of resources. Fields must be specified, to be returned.

Many field names changed. Most commonly in the provider: title -> name modifiedDate -> modifiedTime fileSize -> size

etags are no longer available from GoogleDrive

exportLinks are no longer available in the 'file' representation of GoogleDoc files.

GD v3 returns lists of resources as either 'files' or 'revisions' as opposed to GD v2 which returned 'items' for all resource lists.

Side effects

None expected

QA Notes

This provider will need a full test of all functionality.

Deployment Notes

We will need to keep an eye on 'End of Life' announcements for GoogleDrive v2 API. As we have kept v2 call for GoogleDocs revisions downloads.

TomBaxter avatar Oct 02 '17 20:10 TomBaxter

Coverage Status

Coverage increased (+0.08%) to 89.091% when pulling d7c8a4e0a48d146b79bdfa98f77595a749cbec94 on TomBaxter:feature/osf-426 into 481c9d97cdce74a1e17cbaee9b9095976104e7e3 on CenterForOpenScience:develop.

coveralls avatar Oct 17 '17 16:10 coveralls

Coverage Status

Coverage increased (+0.9%) to 90.003% when pulling e790d6d44072fc66b62abefc69a7340043a98e55 on TomBaxter:feature/osf-426 into 473191c78c36b6ee63d4609d3952a317ee4ab63e on CenterForOpenScience:develop.

coveralls avatar Nov 13 '17 18:11 coveralls

Coverage Status

Coverage increased (+0.06%) to 90.003% when pulling b0e31a21a63a30b380102031a0614091482903c5 on TomBaxter:feature/osf-426 into 26bf2093c15af333e634f14372709e7bf014ccb4 on CenterForOpenScience:develop.

coveralls avatar Nov 13 '17 23:11 coveralls

@TomBaxter Let's sit down and do an in-person review for this.

cslzchen avatar Nov 29 '17 16:11 cslzchen

Coverage Status

Coverage increased (+0.03%) to 89.802% when pulling f3d87c5231a170a6b4a202ebb03244f3b57e576c on TomBaxter:feature/osf-426 into 3ec764ae879c107c405d67b1e2d60d1018eafa96 on CenterForOpenScience:develop.

coveralls avatar Dec 18 '17 16:12 coveralls

Coverage Status

Coverage increased (+0.03%) to 89.898% when pulling 85d497bb08e6ce6b454e2265df7e2a1ebe6203d4 on TomBaxter:feature/osf-426 into cae41fcbde459a4a153bd492de3ddbea90241139 on CenterForOpenScience:develop.

coveralls avatar Jan 03 '18 23:01 coveralls

Coverage Status

Coverage increased (+0.03%) to 89.907% when pulling ac5dc544db8463b115d4da43547e196f7da5ed4f on TomBaxter:feature/osf-426 into f17d27645a67c9d670d8b99ed6bb96891af3cf8f on CenterForOpenScience:develop.

coveralls avatar Jan 05 '18 20:01 coveralls

Update: secondary PR https://github.com/TomBaxter/waterbutler/pull/1 pending.

cslzchen avatar Jan 05 '18 20:01 cslzchen

Coverage Status

Coverage increased (+0.03%) to 89.912% when pulling 6be0f454f4b218e44db6b436e8c2bfb1a21339cc on TomBaxter:feature/osf-426 into f17d27645a67c9d670d8b99ed6bb96891af3cf8f on CenterForOpenScience:develop.

coveralls avatar Jan 08 '18 16:01 coveralls

Update: a second secondary PR https://github.com/TomBaxter/waterbutler/pull/2 pending.

cslzchen avatar Jan 09 '18 02:01 cslzchen

Coverage Status

Coverage increased (+0.1%) to 90.019% when pulling 9f314e93f57caeb6ae1abceb85df8173a596eea1 on TomBaxter:feature/osf-426 into f17d27645a67c9d670d8b99ed6bb96891af3cf8f on CenterForOpenScience:develop.

coveralls avatar Jan 09 '18 16:01 coveralls