waterbutler icon indicating copy to clipboard operation
waterbutler copied to clipboard

[SVCS-256] Adding "undecoded_path" to providers

Open AddisonSchiller opened this issue 7 years ago • 6 comments

refs: https://openscience.atlassian.net/browse/SVCS-256

Purpose

We need the un-decoded file name to distinguish between files with special characters. ie: "me/ow.txt and me%2Fow.txt" The decoding tornado does makes these files hard to distinguish.

Summary of changes

Added an "undecoded_path" variable to the base_provider. This gets set in the "prepare" function to be the undecoded_path received from the request. The path is pulled from 'self.request.uri'

QA

QA will come on individual tickets for providers

AddisonSchiller avatar Aug 23 '17 18:08 AddisonSchiller

Coverage Status

Coverage increased (+0.008%) to 76.688% when pulling 7ea50793e50e358580a67d670aaaee881d395b9b on AddisonSchiller:feature/url_decode into b787a92c180697cb8fb2f5b6c402cf7b931b339d on CenterForOpenScience:develop.

coveralls avatar Aug 23 '17 19:08 coveralls

Coverage Status

Coverage increased (+0.02%) to 79.342% when pulling a19fc66b3452e0f6397e63fe7a3976c7c8f79ee7 on AddisonSchiller:feature/url_decode into 879aedd4a424f5079929cf435c1cebe80e0cc2f7 on CenterForOpenScience:develop.

coveralls avatar Sep 11 '17 17:09 coveralls

Coverage Status

Coverage increased (+0.02%) to 79.342% when pulling a19fc66b3452e0f6397e63fe7a3976c7c8f79ee7 on AddisonSchiller:feature/url_decode into 879aedd4a424f5079929cf435c1cebe80e0cc2f7 on CenterForOpenScience:develop.

coveralls avatar Sep 11 '17 17:09 coveralls

Added requested Changes

AddisonSchiller avatar Sep 11 '17 17:09 AddisonSchiller

Coverage Status

Coverage increased (+0.02%) to 79.342% when pulling a8717a57a02d9741cabb1a2ed9d452174c49c763 on AddisonSchiller:feature/url_decode into 879aedd4a424f5079929cf435c1cebe80e0cc2f7 on CenterForOpenScience:develop.

coveralls avatar Sep 11 '17 17:09 coveralls

@AddisonSchiller Might want to wrap up this conflict.

Johnetordoff avatar Nov 28 '17 18:11 Johnetordoff