waterbutler icon indicating copy to clipboard operation
waterbutler copied to clipboard

Published 20 hours ago • verified publisher icon CenterForOpenScience

[SVCS-132] Factor out move/copy code

Open Johnetordoff opened this issue 7 years ago • 3 comments

Purpose

If WB core provider the move and copy code repeats itself unnecessarily this factors it out and cleans up the functions substantially.

Changes

Moves the metrics, name handling and intra_move/copy code into a decorator which wraps the move and copy functions, also adds/updates some docstrings. Changes some keyword arguments to positional arguments.

Side Effects

None that I know of.

Ticket

https://openscience.atlassian.net/browse/SVCS-132

Johnetordoff avatar Apr 13 '17 15:04 Johnetordoff

Coverage Status

Coverage decreased (-0.03%) to 75.204% when pulling 188b4a313b6267370f48f53cf025818f0664654a on Johnetordoff:DRY-move-or-copy into 753bdd2434b757d889aae6d9b6e9c9c3a650e9dc on CenterForOpenScience:develop.

coveralls avatar May 30 '17 13:05 coveralls

Coverage Status

Coverage decreased (-0.002%) to 89.879% when pulling 465685935c1782743d37b3a69f57551d28a4bdb9 on Johnetordoff:DRY-move-or-copy into e2e626680cba93dbd4e99cc789c26d3fd248704a on CenterForOpenScience:develop.

coveralls avatar Nov 16 '17 21:11 coveralls

Need to make it not a decorator

NyanHelsing avatar Jul 16 '18 16:07 NyanHelsing