waterbutler icon indicating copy to clipboard operation
waterbutler copied to clipboard

Published 20 hours ago • verified publisher icon CenterForOpenScience

[SVCS-137] stop passing query params as kwargs

Open Johnetordoff opened this issue 7 years ago • 3 comments

Purpose

Stops Waterbutler from passing query params as kwargs, this prevents 500 when params (like 'path') overwrite real params.

Changes

Minor refactoring

Side Effects

None that I know of.

Ticket

https://openscience.atlassian.net/browse/SVCS-137

Johnetordoff avatar Apr 06 '17 20:04 Johnetordoff

Coverage Status

Coverage remained the same at 76.68% when pulling 0ffcbdc1b8eb48dd795879357fe693139e9c521c on Johnetordoff:stop-passing-query-params-as-kwargs into b787a92c180697cb8fb2f5b6c402cf7b931b339d on CenterForOpenScience:develop.

coveralls avatar Aug 28 '17 16:08 coveralls

Coverage Status

Coverage remained the same at 89.987% when pulling 203990f1076513a132f018eec8d31171cd463fb3 on Johnetordoff:stop-passing-query-params-as-kwargs into 79583070677e27c7bd13ab8536f195e9ce8041db on CenterForOpenScience:develop.

coveralls avatar Jan 11 '18 20:01 coveralls

Waiting on v0 removal. Waiting on update for all providers' signatures.

NyanHelsing avatar Jul 02 '18 15:07 NyanHelsing