osf.io
osf.io copied to clipboard
CenterForOpenScience
[ENG-968] Polishing utilization of new employment/education model
Purpose
Bringing the model up to date and removing references to it.
Changes
-Modifying and removing some tests for the old education/employment model. Changing code to utilize new education/employment. Some functionality was removed that will need to be added back in -User admin serializer for spam content check on education/employment was removed -Education/Employment was removed from elastic search. Need to discuss in a new ticket about replacing this -Adding new api tests
QA Notes
Documentation
Need to update documentation to remove usage of old education/employment mode.
Side Effects
Could present issues for current utilization of education/employment
Ticket
https://openscience.atlassian.net/browse/ENG-968
@corbinSanders Looks like there are some test failures. Could you check on those?
@corbinSanders Looks like there are some test failures. Could you check on those?
These tests passed locally. Could I get a cache reset?
Are you up to date with develop?
Dawn just updated the feature branch. Rebased my branch. Rerunning.
Both of those tests are passing locally 🤔
Link to passing test; the only think I can think of is that's it's an odd combination of the target branch vs. develop, but we can explore more later if it's still a problem on as this gets merged into upstream feature/norm_education_employment.
