osf.io icon indicating copy to clipboard operation
osf.io copied to clipboard

Published 20 hours ago • verified publisher icon CenterForOpenScience

[ENG-367][Part 1] Use pre-commit to format more of codebase

Open Johnetordoff opened this issue 5 years ago • 4 comments

⚠️ This PR has been split into multiple parts to make for easier CR, this is the only part in the current sprint. ⚠️

Important - will need to get up to date with develop one last time before merging!

Purpose

Lets lint everything! This makes add-trailing-comma hook apply to ever file.

Changes

  • expand coverage to for pre-commit hook for trailing commas to affect : admin/ admin_tests/ osf/ directories.

QA Notes

No need for QA team, dev facing only.

Documentation

Not user facing.

Side Effects

None that I know of.

Ticket

https://openscience.atlassian.net/browse/ENG-367

Johnetordoff avatar Aug 01 '19 19:08 Johnetordoff

Hooray for linting! ⭐️

corbinSanders avatar Aug 02 '19 19:08 corbinSanders

@Johnetordoff Could you resolve this conflict, please?

brianjgeiger avatar Aug 26 '19 19:08 brianjgeiger

my fault @brianjgeiger, John asked me the limit and I said 2K because that's about my tolerance for double-checking changes like this - we can go smaller though!

pattisdr avatar Aug 26 '19 19:08 pattisdr

@pattisdr I recovered. Eventually. :)

brianjgeiger avatar Aug 26 '19 20:08 brianjgeiger