osf.io
osf.io copied to clipboard
CenterForOpenScience
Rnd discourse
Purpose
This PR is being made to link the ongoing Discourse Integration project code to the main OSF.
Changes
framework.discourse module for interaction. Discourse IDs and hooks added to project, file, and wiki node classes. Single-Sign-On for Discourse through the OSF. Completely different comment-pane. Forum-feed Mithril component. See the README.md file in framework/discourse for more.
Example screenshots:
Side effects
Replacing of standard comments with Discourse. Comments will work differently. The APIv2 comment functionality would be broken.
It's Autumn Cleaning time, so I'm closing this PR. Feel free to re-open when development becomes active again.
Hmmm... This was opened originally at Steve Loria's request so that my personal branch would be tied to the COS. Also, it is under active development! But I'm not sure if the PR needs to be open or if anything else should be happening with that.
On Tue, Oct 4, 2016 at 9:59 AM, Brian J. Geiger [email protected] wrote:
It's Autumn Cleaning time, so I'm closing this PR. Feel free to re-open when development becomes active again.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_CenterForOpenScience_osf.io_pull_6151-23issuecomment-2D251395753&d=CwMCaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=7fC-iE5nc1K0x8FY3MV5uEZng4gqi25wl7nIyZPmvbE&m=sjWQ-KTVWMgR017nGuihAvuEdanv_eigVtYu_iQZgtM&s=YCf6WgGlbVweswNZcehKpOMreiPEVitwY_ZqXVFQ5qw&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABYf9sYS-2DkKzakDkI9ZIEKqKONelNtqKks5qwluygaJpZM4JjUZZ&d=CwMCaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=7fC-iE5nc1K0x8FY3MV5uEZng4gqi25wl7nIyZPmvbE&m=sjWQ-KTVWMgR017nGuihAvuEdanv_eigVtYu_iQZgtM&s=evS5dueN9Mk-qJ3dp7dL-wjiDlK65mmuEXhxhv37x6E&e= .
Cool. When you're ready to do another push, go ahead and re-open it then. For now, we should still have access to it for what we need. We just had a lot of open PRs that I was asked to clean out.
Ah, it was only 7 days since the last push. Okay, I'll re-open. From the way Github showed it, I thought it had been months.
I'm trying to install this on my local setup (finally!), and when I invoke the server I'm getting:
File "/Users/bgeiger/cos/osf/osf/models/user.py", line 368, in OSFUser
discourse_apikey_date_created = NonNaiveDatetimeField(default=None, null=True, blank=True)
NameError: name 'NonNaiveDatetimeField' is not defined
I've invoked all the requirements that I could (using the -q flag). Is there anything that maybe isn't in a requirements file?
@brianjgeiger Sorry about the delay in a response. I think this must be from some recent change to the develop branch of osf.io. I recently did a rebase, but haven't gone through running all the code again. I am a little reluctant to, because my environment has diverged substantially since I can't run docker in the specified way. (I don't have a recent-year mac). By and large, I aimed to use the same conventions as the OSF already was. That specific datetime field type is not important as long as it is consistent.
This should definitely not try to be merged with develop. The branch itself should be, for the purposes of this review, its own island. If it's in a partway state, then I'm not going to be able to get it running. Can this be rolled back to a last-known working state?
Well, NonNaiveDatetimeField is actually just a typo. It should be NonNaiveDateTimeField. For me to really be sure it is working on either an older rollback or this version might take a little (I'm not super familiar with undoing a rebase), so be patient with me as I try to find time to look more at this now.
@brianjgeiger I've fixed the typo and I can get it to run locally. However, the amount of testing I can do is limited right now since I'm having trouble being able to create an account on my new instance. I get the error: "Invalid Token This confirmation link is invalid." when trying to make a new account.