osf.io icon indicating copy to clipboard operation
osf.io copied to clipboard

[POC] Fix preprint state machine

Open Johnetordoff opened this issue 7 months ago • 0 comments

Purpose

Erase tech debt from old state machine implementation.

Changes

  • Standerize triggers and states using ModerationEnum
  • Separate overlapping transitions to make them more declaritive and indepenent of each other
  • Intestate state machine on model so validation works (fix MachinableMixin)
  • Write validation for before state transitions
  • Write after behavior to conform to tests.
  • ReviewActionSerializer should improve in code quality

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

Johnetordoff avatar Jul 15 '24 16:07 Johnetordoff