osf.io icon indicating copy to clipboard operation
osf.io copied to clipboard

update for module file renderer

Open jonathon-love opened this issue 2 years ago • 2 comments

hi,

i've opened a quite simple PR over here several weeks ago.

is osf still being actively maintained, or do i need to temper my expectations?

with thanks

jonathon-love avatar Aug 02 '22 07:08 jonathon-love

Sorry about that, MFR doesn't always get as much attention as other parts of our codebase. Tagging @felliott to take a look, but seems non-controversial to me. Also, congrats on (unintentionally) swiping issue #10000 from us and guaranteeing you got our attention 😂

Thanks for the contribution!

jwalz avatar Aug 02 '22 15:08 jwalz

Follow-up: @felliott is out and I just did a CR, it looks great with one nitpick which is to update unit tests, thanks!

cslzchen avatar Aug 02 '22 20:08 cslzchen