cos.io icon indicating copy to clipboard operation
cos.io copied to clipboard

[bug] tab links on statististical* consulting page don't work

Open felliott opened this issue 8 years ago • 7 comments

Issue

Go to https://cos.io/stats_consulting/. Give the page a few seconds to load all of its assets. Click on "Statistical and Methodological Consulting" under the "We offer free" header.

I'd expect to be taken to the Statistical Consulting tab, but nothing happens. Clicking directly on the tab works as expected.

screen shot 2016-08-02 at 4 55 56 pm

Symptoms

When loading the page with an anchor, two assets don't load:

screen shot 2016-08-02 at 4 58 20 pm

  • I declare this the new official spelling of "statistical".

felliott avatar Aug 02 '16 21:08 felliott

Hey @csoderberg @aprilcs @jolene-esposito: can one of you help with a fix for this? Thanks!

saradbowman avatar Aug 02 '16 21:08 saradbowman

I think it's going to be a bigger fix than we anticipate since it has something to do with the tabs. The quickest fix right now is to just unlink them and let people navigate the page using just the tabs.

jolene-esposito avatar Aug 03 '16 13:08 jolene-esposito

I am happy to help in anyway I can, but the tabs were working on the staged version Courtney made, so I don't have the expertise to know why they don't work live. If Jolene's suggestion works in the meantime, let's do that to start.

aprilcs avatar Aug 03 '16 13:08 aprilcs

I took a quick peek, and I think the paths to the JS at the bottom of the mako file are wrong. I'll submit a quick PR.

felliott avatar Aug 03 '16 14:08 felliott

PR: https://github.com/CenterForOpenScience/centerforopenscience.org/pull/723

This will fix the 404s, which might fix this issue.

felliott avatar Aug 03 '16 14:08 felliott

If the above PR doesn't fix it, then I think I know what the problem is. For the links, I put the url for each tab, but instead I should have used something like this:

Statistical Consulting

so that the page automatically switches to the tab, rather than having to refresh the page to get it to move to the new tab, which is what is happening now.

csoderberg avatar Aug 03 '16 14:08 csoderberg

Thanks for looking into this Fitz! I looked, but couldn't find the problem. But, I also don't know that much about the codebase. haha.

jolene-esposito avatar Aug 03 '16 14:08 jolene-esposito