Celestia icon indicating copy to clipboard operation
Celestia copied to clipboard

Update children positions when parent body is modified

Open 375gnu opened this issue 1 year ago • 6 comments

At least with the build from the pull request, locations on Ceres are fixed with its actual oblateness, but I just found that if I modify an object to increase its oblateness to 0.5, locations are still floating in space: flatmars

Originally posted by @SevenSpheres in https://github.com/CelestiaProject/Celestia/issues/1557#issuecomment-1666610049

375gnu avatar Aug 06 '23 07:08 375gnu

@SevenSpheres are you sure that you tested a proper build? That's what I have with the today's master: image

375gnu avatar Aug 08 '23 15:08 375gnu

works for me too (linux/qt5/master) blubb

munix9 avatar Aug 08 '23 15:08 munix9

Still looks like my screenshot on the latest build. Tested on Win32, Qt5, and Qt6 frontends.

SevenSpheres avatar Aug 09 '23 15:08 SevenSpheres

I can reproduce both cases.

  • If you edit the oblateness of Mars by editing solarsys.ssc, the location positions work.
  • If you set it via a modification rule, e.g. Modify "Mars" "Sol" { Oblateness 0.5 } then the location positions will not be updated and will be floating in space.

ajtribick avatar Aug 09 '23 17:08 ajtribick

Can confirm, so this is probably a non-issue

SevenSpheres avatar Aug 09 '23 18:08 SevenSpheres

Then we need to recompute children positions on modification.

375gnu avatar Aug 10 '23 08:08 375gnu