Celestia icon indicating copy to clipboard operation
Celestia copied to clipboard

Black square around the Sun

Open 375gnu opened this issue 1 year ago • 13 comments

image

I was able to reproduce it with GTK frontend only.

Steps to reproduce: enable planet orbits, go to cel://Follow/Sol:Earth/2022-09-01T14:05:06.49829Z?x=MHL9zpmPEv///////////w&y=NP4T6lFEn////////////w&z=bE++EAGevP///////////w&ow=0.2696041&ox=0.61314183&oy=0.020633211&oz=0.7422567&fov=46.849846&ts=1.0&ltd=0&p=0&rf=136181183&nrf=255&lm=0&tsrc=0&ver=3

Maybe moving up & high will be required. Also depends on distance to the Sun. Much easier to reproduce with a small window: image cel://Follow/Sol/2022-09-01T14:08:01.61868Z?x=AAB9QrTiPKgR&y=LCAzq32hzP///////////w&z=AIBlhuWIg9cG&ow=0.20013171&ox=0.54564375&oy=-0.145735&oz=0.8006132&select=Sol&fov=23.575752&ts=1.0&ltd=0&p=0&rf=136181183&nrf=191&lm=0&tsrc=0&ver=3

375gnu avatar Sep 01 '22 14:09 375gnu

i confirm the presence of this bug. it seems to also affect planets and moons? image i can only reproduce the second image you attached if the window is shrunk down greatly image image showing the effect on planets and moons image cel://URL for last image: cel://Follow/Sol/2022-09-01T14:10:05.12862Z?x=AAAT/1qIQQYP&y=wDDLX9OwFwU&z=AIBAolMvCNIF&ow=-0.20438017&ox=-0.54770637&oy=0.13927919&oz=-0.7992796&select=Sol&fov=23.575752&ts=1&ltd=0&p=0&rf=136181183&nrf=191&lm=0&tsrc=0&ver=3

TheLostProbe avatar Sep 01 '22 23:09 TheLostProbe

i was able to fully confirm that this does indeed happen with planets. it also occurs around other stars. the bug is visible on planets with both the Fuzzy Points and Scaled Discs rendering options

cel://Follow/TOI-3207:TOI-3207.01/2022-09-02T00:09:44.82531Z?x=AOCydhdqsjP//////////w&y=AFCKtkxEtlb+/////////w&z=AABD6dmrQAoB&ow=-0.4358858&ox=0.41791612&oy=0.28216168&oz=-0.745476&select=TOI-3207:TOI-3207.01&fov=125.02859&ts=1&ltd=0&p=0&rf=138253747&nrf=255&lm=2048&tsrc=0&ver=3 image cel://Follow/TOI-3207:TOI-3207.01/2022-09-02T00:08:55.80747Z?x=AOCJS69fo8n//////////w&y=ALCs/MjZxlI&z=AGB+lABCRb4C&ow=-0.4311777&ox=0.009358624&oy=-0.06936029&oz=-0.8995484&select=TOI-3207:TOI-3207.01&fov=125.02859&ts=1&ltd=0&p=0&rf=138253747&nrf=255&lm=2048&tsrc=0&ver=3 image

TheLostProbe avatar Sep 02 '22 00:09 TheLostProbe

i have confirmed that it happens with moons, but only under Scaled Discs mode image

TheLostProbe avatar Sep 06 '22 10:09 TheLostProbe

oh god, its getting worse... it affects stars in the vicinity of nebula models now. it appears to flicker when zooming in and out and orbiting the camera around this addon is required for the Cel://URLs to work

cel://Follow/NGC2237/2022-09-08T10:22:28.16962Z?x=AAAAANiTPPB03b4&y=AAAAAAAqS0ACWnX7/////w&z=AAAAAIAznp7VCrgC&ow=0.8684787&ox=-0.48982716&oy=-0.07583937&oz=-0.007906457&select=NGC2237&fov=30.375284&ts=1&ltd=0&p=0&rf=138204563&nrf=255&lm=2048&tsrc=0&ver=3 image

it is also visible when zooming in

cel://Follow/NGC2237/2022-09-08T10:19:07.20068Z?x=AAAAAACUBn3viar3/////w&y=AAAAAABKuOgc0KYz&z=AAAAAABILdgi5NaU&ow=0.9856167&ox=0.16648185&oy=0.02404564&oz=-0.016290106&select=NGC2237&fov=7.028166&ts=1&ltd=0&p=0&rf=138204563&nrf=255&lm=2048&tsrc=0&ver=3 image

Fuzzy Points is also affected

cel://Follow/NGC2237/2022-09-08T10:21:51.22317Z?x=AAAAAGiJfVEgLyg&y=AAAAAIBdeKY8G7n1/////w&z=AAAAAEC46cXvNrkE&ow=0.8418962&ox=-0.5395627&oy=-0.009023483&oz=0.0012202401&select=NGC2237&fov=30.375284&ts=1&ltd=0&p=0&rf=138204563&nrf=255&lm=2048&tsrc=0&ver=3 image

TheLostProbe avatar Sep 08 '22 08:09 TheLostProbe

wow this bug is beyond insane, just look at this!

cel://Follow/NGC2237/2022-09-08T10:28:33.11079Z?x=AAAAAMD1ImW6mR35/////w&y=AAAAAAAnnmgEgH7u/////w&z=AAAAAADemCQ6XVDT/////w&ow=0.12621187&ox=-0.8580762&oy=-0.47385523&oz=0.15243697&select=NGC2237&fov=30.375284&ts=1&ltd=0&p=0&rf=137942419&nrf=255&lm=2048&tsrc=0&ver=3 image

it appears that depth sorting issues are occurring too

cel://Follow/NGC2237/2022-09-08T10:29:33.48194Z?x=AAAAACAQTBfUCTD+/////w&y=AAAAAHBxR+OjisA&z=AAAAAEedjOLrWho&ow=0.3535039&ox=-0.20803428&oy=0.695492&oz=0.58995557&select=NGC2237&fov=30.375284&ts=1&ltd=0&p=0&rf=137942419&nrf=255&lm=2048&tsrc=0&ver=3 image

TheLostProbe avatar Sep 08 '22 08:09 TheLostProbe

I have been unable able to repro on iOS, Mac(GL or ANGLE+Metal). if you are on windows 10/11, you can also try to use the UWP version https://celestia.mobi/download/uwp.html to test.

levinli303 avatar Sep 08 '22 13:09 levinli303

well, i have seen a few unrelated problems in the UWP version, but i will make issues for them later. the focus of this issue is black squares around stars, and not anything else.

it doesnt look like the UWP version has the issue, at least for stars. as for planets though... cel://Follow/Sol:Earth/2022-09-09T06:38:42.14279Z?x=AA5fdg0Zbzk&y=ADOgu5wAywU&z=wBnMAUQ2IAQ&ow=0.6814089&ox=-0.006964908&oy=-0.72724324&oz=-0.08216254&select=Sol:Earth&fov=29.356295&ts=1&ltd=0&p=0&rf=205428663&nrf=255&lm=2048&tsrc=0&ver=3 image

however, turning up the mag limit makes it look like there isnt a black square around the planets, but instead a transparent square that renders in front of the orbits but behind the stars? cel://Follow/Sol:Earth/2022-09-09T06:40:57.89695Z?x=AOZgXP3b5iY&y=wPdzf6d77AM&z=IPzWpp9nywI&ow=0.6814089&ox=-0.006964908&oy=-0.72724324&oz=-0.08216254&select=Sol:Earth&fov=29.356295&ts=1&ltd=0&p=0&rf=205428663&nrf=255&lm=2048&tsrc=0&ver=3 image

i will see later if i can access a macOS device and test, perhaps also an iOS device

TheLostProbe avatar Sep 09 '22 06:09 TheLostProbe

I fail to see what is wrong in the screenshots. the UWP build on the store does not include recent changes in celestia repo.

for iOS, please use TestFlight build instead of AppStore as the TestFlight build is up to date https://celestia.mobi/download/testflight.html

for Mac try https://dev.azure.com/CelestiaProject/Celestia/_build/results?buildId=1868&view=artifacts&pathAsName=false&type=publishedArtifacts either macosx-developerID-metalAngle/macosx-developerID-openGL

I would actually recommend focusing on one platform, getting history builds to see on what date in this repo this starts occurring.

levinli303 avatar Sep 09 '22 07:09 levinli303

sorry, i shouldve highlighted the problems in the screenshots. my bad! image image

TheLostProbe avatar Sep 09 '22 08:09 TheLostProbe

@TheLostProbe this might be https://github.com/CelestiaProject/Celestia/issues/1414

levinli303 avatar Sep 09 '22 10:09 levinli303

maybe, but zooming in or out makes the problem go away, it only happens at a very specific angle and distance

TheLostProbe avatar Sep 09 '22 23:09 TheLostProbe

@375gnu looks like it occurs on Qt as well

cel://Follow/Sol:Earth/2022-09-14T01:03:36.66367Z?x=qFq+ZaaewQ&y=A6MDegZPCw&z=IBCopm84zQ&ow=0.8622763&ox=-0.016966807&oy=-0.49758482&oz=-0.09274156&select=Sol:Earth&fov=29.214388&ts=1&ltd=0&p=0&rf=136370099&nrf=255&lm=14342&tsrc=0&ver=3 image

TheLostProbe avatar Sep 14 '22 01:09 TheLostProbe

maybe, but zooming in or out makes the problem go away, it only happens at a very specific angle and distance

this is expected with the issue #1414

levinli303 avatar Sep 14 '22 12:09 levinli303

now there are 2 black boxes around the stars

cel://Follow/Sol:Earth/2010-08-12T13:44:31.91561Z?x=AAAAAOcdUgquMun//////w&y=AAAAACbbEPf/Odb//////w&z=AAAAAAiY96wrLtL//////w&ow=0.7524634&ox=0.07473861&oy=-0.29202974&oz=-0.5856036&fov=69.448135&ts=1&ltd=0&p=0&rf=134862215&nrf=255&lm=4&tsrc=0&ver=3 image

TheLostProbe avatar Sep 23 '22 08:09 TheLostProbe

this error has been fixed by #1446

TheLostProbe avatar Oct 23 '22 21:10 TheLostProbe