Missing licence file

[natewrench]

Describe the bug A clear and concise description of what the bug is. The license button is unable to open file copying due to improper installation

To Reproduce Steps to reproduce the behavior:

1. Go to 'Help'
2. Click on 'About'
3. Scroll down to 'License'
4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. GNU/Linux, Windows, macOS] Linux Mint 20.3
• Frontend: [e.g. Qt, native Win, native Mac] GTK+ Front End
• Version: [e.g. 1.7.0] 1.6.1

Additional context Add any other context about the problem here.

[375gnu]

@natewrench where you installed Celestia from?

[ghost]

@natewrench where you installed Celestia from?

celestia.space

[375gnu]

@natewrench don't close, as the packages came from celestia.space then we should fix them.

[dave-kaye]

Placed a proposed fix in the pull requests.

[dave-kaye]

Commit 6873d44 fixed this issue on 1.7.0, - recent compile works.

Downloaded 1.6.2.2 source rpm from munix9 and compiled it. It also works. Version 1.6.1 is very old but seems that it should also work. Appears that problem is probably in Mint Linux, and the version quoted is also old.

I think the issue is resolved and can be closed.

[dave-kaye]

@375gnu or @levinli303 please mark this issue #1389 as corrected and remove it from the list. I have downloaded and installed the patched 1.7.0 development GIT 12/24/22 code and it works for the GTK About -> license, using my own Linux installation which uses the Cmake file supplied with Celestia. I have also made a new openSUSE Tumbleweed installation and used munix9 Tumbleweed rpms from the 1.7.0 Celestia 12/4/22 GIT version. They move the license file to a special directory as practiced by openSUSE. But the corrected code made a copy of the license file in the location needed by GTK and munix9's version worked as well. Therefore the issue appears to be resolved in the presently being developed code.

Using munix9 rpms I compiled Celestia 1.6.2.2 GTK and About -> license is working without the need for an error correction. Once again, munix9 moves the license file to a special directory as practiced by openSUSE. But the install files keep a copy of the license file in the location needed by GTK.

I am unable to compile Celestia GTK 1.6.1 due to old automake and autoconfig files. However, the make files show that the license file is being installed to the same directory and the code for the GTK about box is the same for versions 1.6.2.2 and 1.6.1, so it should be working as well.

The issue is for Linux Mint 20.3 using Celestia 1.6.1. 375gnu stated that celestia.space should be corrected. But no direct link to 1.6.1 exists on the download page for Linux - only links to Windows and MacOS versions. Both Windows and MacOS have interface code ported to their system, and do not use GTK. Links to Linux versions are from a repository maintained by @munix9, and there the versions found are 1.6.2.2 and 1.7.0.

It would not appear that celestia.space needs to be corrected. The user probably got a version 1.6.1 a while ago from celestia.space and is still using it.

[375gnu]

Fixed in 1.6.4-2 available from https://celestiaproject.space/deb.html / https://celestiaproject.space/ubnt.html