Celestia icon indicating copy to clipboard operation
Celestia copied to clipboard

CELX starcolor/starstyle with menu item sync

Open CelestiaProject opened this issue 7 years ago • 11 comments

New CELX commands have been added:

celestia:setstarcolor()
celestia:setstarstyle()

When executed, the new values are stored in the registry, but the menu items (Render->Star style & render->Star color) do not change their position (not synchronized).

CelestiaProject avatar Mar 28 '17 09:03 CelestiaProject

At the same time, need to correct the order of the menu items Render->Star style. Should be:

  • Points
  • Fuzzy Points
  • Scaled Discs

CelestiaProject avatar Mar 28 '17 09:03 CelestiaProject

Synchronization with menu for StarStyle described in winmain.cpp - syncMenusWithRendererState() function. Sync for StarColor and TextureResolution added in syncMenusWithRendererState() function by Leserg. But methods celestia:setstarcolor() and celestia:setstarstyle() are not described in the Windows interface, so I can not use syncMenusWithRendererState() function for synchronization.

Alexell avatar Mar 28 '17 14:03 Alexell

Render->Star style order I'll do today.

Alexell avatar Mar 28 '17 14:03 Alexell

Changed order of Render->Star style menu items (f79990a)

Alexell avatar Mar 28 '17 14:03 Alexell

Need to create StarStyle & StarColor sync with menu.

CelestiaProject avatar Mar 28 '17 15:03 CelestiaProject

Need to check for QT.

Alexell avatar Jun 06 '18 12:06 Alexell

syncMenusWithRendererState is a bad implementation of this idea.

Actually we should introduce hook(s) called when script change application state.

375gnu avatar Jul 13 '18 15:07 375gnu

btw, in qt version celestia:setstarstyle() changes menus.

375gnu avatar Oct 07 '18 20:10 375gnu

Win native UI is doomed as nobody wants to maintain it. I don't think this issue will have any care.

375gnu avatar Jul 02 '23 13:07 375gnu

Have you fully switched to QT?

Alexell avatar Jul 02 '23 16:07 Alexell

Not yet, but Qt is the only UI which has support.

375gnu avatar Jul 02 '23 18:07 375gnu