QCefView icon indicating copy to clipboard operation
QCefView copied to clipboard

Adapt cef 106

Open HO-COOH opened this issue 1 year ago • 2 comments

I adapted cef 106, so now the project can be built with latest cef 106 binary. Two breaking changes from cef are:

  1. Add CefBaseTime and use it instead of CefTime (see issue #2935) Cef commit hash 27d308980414432ee69bdc16dae7cb16a6aaa2b9
  2. Delete cef_web_plugin.h and plugin-related APIs (see issue #3047) Cef commit hash 28c7f040016a0271ec2612cc5021599fb55a1054

HO-COOH avatar Oct 16 '22 18:10 HO-COOH

@HO-COOH Thank you for your work. The code looks very good! But you meed to update the CEF version in QCefViweCore and submit PR to that project first. Then you just update the sub module in project QCefView and submit PR to this project.

tishion avatar Oct 17 '22 00:10 tishion

This workaround would require a modification in CefConfig.cmake file of the CefViewCore project that parses the cef version macro. Please tell me whether this approach is acceptable.

HO-COOH avatar Oct 17 '22 17:10 HO-COOH

move to #167

tishion avatar Oct 25 '22 14:10 tishion