Client icon indicating copy to clipboard operation
Client copied to clipboard

System.Diagnostics.Activity support

Open luckyycode opened this issue 2 years ago • 1 comments

Since even Microsoft has started to integrate this ability to built-in classes (take a look on HttpClient) and with the growth of OpenTelemetry package, I'd like to make a proposal to integrate System.Diagnostics into CatraProto.

It does not require any thirdparty package and it's already integrated into net 5+ sdk. See https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.activitysource?view=net-6.0

Why?

It will be easier to find out any freezes or long executing methods using this thing. It will really help to diagnose any abnormal activity when using CatraProto. (For example, take a look on how it looks in Jaeger, Zipkin and sooo on, these are importers of telemetry and activities).

My proposal is made of a simple idea: insert ActivitySource into each publicly available CatraProto api method, with tags and requested data, that will make it easier to use for users and developers, unless needed.

luckyycode avatar Aug 01 '22 21:08 luckyycode