Android icon indicating copy to clipboard operation
Android copied to clipboard

Password protection of app

Open TheLastProject opened this issue 5 years ago • 22 comments

Issue by MPK44 Saturday Jul 25, 2020 at 08:51 GMT Originally opened as https://github.com/brarcher/loyalty-card-locker/issues/370


it would be cool, if one could protect the app with a password from opening. Especially when saving gift card codes (like money)

TheLastProject avatar Oct 24 '20 10:10 TheLastProject

Comment by brarcher Saturday Jul 25, 2020 at 16:12 GMT


There was a request similar to this on another app that I've written. Feel free to review that discussion. Likely it is something that will not be supported in this app. The effort is non-trivial to do it correctly and securely. These days I do not have much time to dedicate to the project.

I thank you for the suggestion, though.

TheLastProject avatar Oct 24 '20 10:10 TheLastProject

Maybe https://github.com/mattsilber/applock is worth considering for this, it looks promising

TheLastProject avatar Nov 26 '20 02:11 TheLastProject

+1 for an optional passlock

trymeouteh avatar Aug 06 '21 19:08 trymeouteh

@TheLastProject Can I take up this issue. I am planning to use the Aitorvs finger lock library {https://github.com/aitorvs/fingerlock} to add the finger lock.

Unreal-Dreams avatar Aug 23 '21 05:08 Unreal-Dreams

Sounds good! Good luck @Unreal-Dreams and tell me if you have questions :)

TheLastProject avatar Aug 23 '21 10:08 TheLastProject

@Unreal-Dreams are you still working on this?

TheLastProject avatar Sep 12 '21 20:09 TheLastProject

I am sorry @TheLastProject due to some unforeseen conditions I won't be able to complete my work on this. I will surely resume if I got a chance. Thank You

Unreal-Dreams avatar Sep 23 '21 15:09 Unreal-Dreams

ezgif com-gif-maker

This is what was supposed to be done right? I'd like to work on this issue. (ps: gif above, will take time to load.)

aditya3901 avatar Oct 04 '21 05:10 aditya3901

Yup, that is indeed the requested feature :)

If this becomes optional (so, it doesn't show when you start the app but you can tap something in settings) that would be right about perfect :)

TheLastProject avatar Oct 04 '21 09:10 TheLastProject

App Lock | Catima Debug

Have a look. Will this work?

aditya3901 avatar Oct 05 '21 04:10 aditya3901

That looks pretty good!

I think we should avoid showing cards until the app is unlocked (if locking is enabled) and I'd rather the configure lock stuff shows up as soon as you toggle App Lock in the settings.

Will need to try it out myself to see if it feels right, but it looks really good so far :)

TheLastProject avatar Oct 05 '21 07:10 TheLastProject

Should I do locking/un-locking stuff in a separate activity then? (For not showing cards) I don't want to mess with the existing code!

aditya3901 avatar Oct 05 '21 08:10 aditya3901

It may be easiest to just extend https://github.com/TheLastProject/Catima/blob/15ba15c602bbed2c3aee18cd5a128c3ee742a67e/app/src/main/java/protect/card_locker/MainActivity.java#L396

to add an if(mDB.getLoyaltyCardCount() > 0 && !appIsLocked()) and just make sure to call the updateLoyaltyCardList function after unlocking

TheLastProject avatar Oct 05 '21 08:10 TheLastProject

App Lock v2 | Catima Debug

Have a look please.

aditya3901 avatar Oct 05 '21 17:10 aditya3901

Looks awesome!

How does it deal with stuff like home screen widgets?

TheLastProject avatar Oct 05 '21 17:10 TheLastProject

catima

I was making the pr. The app builds fine and everything. But due to this error, the pr is showing conflict with main branch. What should I do?

aditya3901 avatar Oct 05 '21 18:10 aditya3901

There is no error in your screenshot?

TheLastProject avatar Oct 05 '21 18:10 TheLastProject

Line 1 : com.github.spotbugs... github showing error

aditya3901 avatar Oct 05 '21 19:10 aditya3901

Nah that's just some weird Android Studio glitch. It shows that as red for me too, but it works just fine. Has been like that for very very long.

TheLastProject avatar Oct 05 '21 19:10 TheLastProject

Ok. Pls check the pr then.

aditya3901 avatar Oct 05 '21 20:10 aditya3901

For those who are viewing this issue now:

The last attempt at fixing this was in #462 but sadly it didn't quite work out. So this feature still doesn't exist. For now I'd recommend just using a device-wide lock code (which I strongly recommend doing anyway, if you don't have any lock code on your device you make a lot of private data very easy to reach if someone steals your phone, including all your contacts and photos).

TheLastProject avatar Jul 28 '24 11:07 TheLastProject

Looks like Android 15 introduces a new "Private space" feature, so for those on Android 15 that is likely an usable option: https://blog.google/products/android/android-15/

TheLastProject avatar Nov 23 '24 21:11 TheLastProject