Card balance changes when Currency is changed

[andbenn]

Love the app! Long time user.

When entering a card that has a balance, the Currency defaults to Points. If the balance field has a decimal point in it, the balance changes when the currency changes.

1. • to start a card
2. Scan a card
3. Move to Options tab
4. Enter balance
5. 25.64
6. Change Currency from Points to $
7. Balance is now 26
8. Now I have to re-enter the balance, 25.64.
9. Save

Maybe swap the Currency and Balance field positions so I do them in sequence when going top to bottom, left to right?

[TheLastProject]

I see what you mean. I'm not sure putting currency on the left will be less confusing though, as "Balance" showing first makes clear it's the currency to the balance. "Currency" alone might be confusing.

Hard to tell what's best here ^^"

[andbenn]

Hrm, yeah. Could the rounding of the balance be stopped upon a currency change?

[TheLastProject]

I looked at your issue more deeply but I think the steps to reproduce are wrong. I mean, sure, what you name can happen, but there is a worse issue at play here:

1. Create/scan a new card
2. Switch to the options screen
3. Observe the default balance type is points
4. Enter a decimal value in the balance field
5. Focus any other field
6. Observe the balance field gets truncated to full integers, because you can't have a decimal amount of points

Rounding on currency changing is in my eyes unavoidable because different currencies use different amount of decimals. Euro uses 2 decimals, but some currencies are only full numbers and some may have 1 or 3 decimals.

However, the default currency being points and points having no decimals causes this issue if you fill in a balance before selecting a currency.

I see multiple options:

1. Default not to points but to the user's device currency: this might make points harder to find
2. Allow points to have decimals: this makes some sense as there is no guarantee no store out there gives you half a point at some point (no pun intended)
3. Indeed switch the fields around, to nudge people to choose a good currency first: opening up to this idea, but we should maybe go for a 25/75 split of field size then? Not sure

[TheLastProject]

Tried swapping them around in #2855. I think it's actually a bit nicer, you see "Points" first now which gives you more context than the number :)

Let's just go for it, worst case can revert :)

[andbenn]

Thank you! I will check this out when the next update arrives. This app is so helpful, I appreciate all your efforts.