Android icon indicating copy to clipboard operation
Android copied to clipboard

Add “Copy value” overflow action to card view

Open Sentinel-Android opened this issue 1 month ago • 6 comments

What’s new

  • Adds Copy value option to the card-view overflow menu.
  • Copies the card’s cardId to the system clipboard via ClipboardManager.
  • New strings: copy_value, copied_to_clipboard, nothing_to_copy.
  • Placed inside existing overflow submenu → no extra toolbar icons.

UX

  1. Open any card.
  2. Tap ⋮ → Copy value.
  3. OS clipboard toast appears -> paste confirms number.

Build variants tested

  • fossDebug on API 34 emulator
  • Feature is in src/main, so it ships with gplay* too.

No database or schema changes; 100 % additive.

Sentinel-Android avatar Oct 22 '25 17:10 Sentinel-Android

From a quick check this probably works, but is there any reason you haven't added this to the dialog that appears when tapping the barcode as decided in #2400?

TheLastProject avatar Oct 23 '25 17:10 TheLastProject

No, I havent checked that. If you want I can implement that too.

On Thu, 23 Oct, 2025, 10:32 pm Sylvia van Os, @.***> wrote:

TheLastProject left a comment (CatimaLoyalty/Android#2789) https://github.com/CatimaLoyalty/Android/pull/2789#issuecomment-3438124705

From a quick check this probably works, but is there any reason you haven't added this to the dialog that appears when tapping the barcode as decided in #2400 https://github.com/CatimaLoyalty/Android/issues/2400?

— Reply to this email directly, view it on GitHub https://github.com/CatimaLoyalty/Android/pull/2789#issuecomment-3438124705, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW32Q3TRKPSFFJRPFXIAKPL3ZEC35AVCNFSM6AAAAACJ5PVNESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZYGEZDINZQGU . You are receiving this because you authored the thread.Message ID: @.***>

Sentinel-Android avatar Oct 23 '25 18:10 Sentinel-Android

I think it would be better to only implement that version (long-press + new button on the dialog on short press) to keep the menu simpler :)

TheLastProject avatar Oct 23 '25 18:10 TheLastProject

Ok, I will try to implement the changes you suggested in the #2400

On Fri, 24 Oct, 2025, 12:23 am Sylvia van Os, @.***> wrote:

TheLastProject left a comment (CatimaLoyalty/Android#2789) https://github.com/CatimaLoyalty/Android/pull/2789#issuecomment-3438626250

I think it would be better to only implement that version (long-press + new button on the dialog on short press) to keep the menu simpler :)

— Reply to this email directly, view it on GitHub https://github.com/CatimaLoyalty/Android/pull/2789#issuecomment-3438626250, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW32Q3XFMW7JUQP6GSR6JWL3ZEP3ZAVCNFSM6AAAAACJ5PVNESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZYGYZDMMRVGA . You are receiving this because you authored the thread.Message ID: @.***>

Sentinel-Android avatar Oct 23 '25 18:10 Sentinel-Android

I have implemented the changes you suggested. Please check.

Sentinel-Android avatar Oct 24 '25 12:10 Sentinel-Android

Is this fine?

On Fri, 24 Oct 2025 at 00:28, Aditya Varma @.***> wrote:

Ok, I will try to implement the changes you suggested in the #2400

On Fri, 24 Oct, 2025, 12:23 am Sylvia van Os, @.***> wrote:

TheLastProject left a comment (CatimaLoyalty/Android#2789) https://github.com/CatimaLoyalty/Android/pull/2789#issuecomment-3438626250

I think it would be better to only implement that version (long-press

  • new button on the dialog on short press) to keep the menu simpler :)

— Reply to this email directly, view it on GitHub https://github.com/CatimaLoyalty/Android/pull/2789#issuecomment-3438626250, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW32Q3XFMW7JUQP6GSR6JWL3ZEP3ZAVCNFSM6AAAAACJ5PVNESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZYGYZDMMRVGA . You are receiving this because you authored the thread.Message ID: @.***>

Sentinel-Android avatar Oct 24 '25 18:10 Sentinel-Android