Android icon indicating copy to clipboard operation
Android copied to clipboard

AboutActivity to Jetpack Compose

Open TheLastProject opened this issue 7 months ago • 2 comments

  • [X] Composify
  • [x] Hide elements when they should be hidden
  • [x] Don't crash when clicking an element
  • [ ] Fix tests
  • [ ] Remove colour selection options in Catima (to simplify migration)
  • [ ] Ensure consistency with other activity designs

TheLastProject avatar May 04 '25 22:05 TheLastProject

Main blocker here is that I haven't found the time to deal with fixing the tests yet (quite a different way of testing) and I'm hesitant to just remove the tests (though maybe I should to at least progress somewhat).

I think the general code is probably pretty OK by now, just needs the custom colour support removed for consistency between XML and Compose.

TheLastProject avatar Jun 24 '25 21:06 TheLastProject

Thanks for the update! I took a look and went ahead with some optimizations in AboutActivity. I’ve also fixed a few of the existing tests and added some new ones to improve coverage. Hopefully, this helps unblock some of the progress you mentioned. Let me know if you’d like me to push these changes for review or if you’d prefer I open a separate PR.

vijay2909 avatar Oct 01 '25 16:10 vijay2909