Android icon indicating copy to clipboard operation
Android copied to clipboard
verified publisher icon CatimaLoyalty

Kotlin conversion/barcode selector activity kt conversion

Open juuce79 opened this issue 9 months ago • 3 comments

Conversion of BarcodeSelectorActivity from java to kotlin code.

  • Manually tested in Android Studio using emulator with APIs 24, 30, 35 and 36
  • Manually tested on physical device using API 33
  • All tests in BarcodeSelectorActivityTests pass
  • Code has been kept as close to the original Java code as possible (structurally) barcode_selector_activity.pdf

juuce79 avatar Mar 14 '25 20:03 juuce79

You seem to have a conflict with BarcodeSelectorActivity.java, which is weird, because that file hasn't changed in 3 years: https://github.com/CatimaLoyalty/Android/commits/main/app/src/main/java/protect/card_locker/BarcodeSelectorAdapter.java

Your commit history seems quite messy, there are commits in there that have already been merged. Can you rebase it on top of the main branch?

TheLastProject avatar Mar 16 '25 17:03 TheLastProject

Hey @juuce79, haven't heard from you for a while. Are you still working on this? Just want to know if I should add your WIP to #2483 :)

TheLastProject avatar May 03 '25 09:05 TheLastProject

Partially superseded by #2585 (the tests weren't converted in that MR, but they are here)

TheLastProject avatar Jul 29 '25 16:07 TheLastProject