syncthing-android icon indicating copy to clipboard operation
syncthing-android copied to clipboard

Ethernet connection as a run condition

Open mikulik86 opened this issue 3 years ago • 12 comments

Hello and thanks to the developer.

Could you please add a ethernet connection as another run condition? Would be great.

mikulik86 avatar Jul 08 '22 16:07 mikulik86

What is the use case why this run condition is so important for you?

Catfriend1 avatar Jul 13 '22 18:07 Catfriend1

I put my phone over night into a flight mode and connect it to a dock for charging and ethernet connectivity. And I want it to sync only then. Not other times when the phone is charging somewhere else where also connected to a Wi-Fi.

mikulik86 avatar Jul 21 '22 18:07 mikulik86

I think the run condition "run in flight mode" could help you out in this scenario.

If you'd like to implement a new run condition, that would be mainly copy and paste in run condition monitor and the layout of the settings screen xml file plus some strings.

Catfriend1 avatar Jul 22 '22 10:07 Catfriend1

I think the run condition "run in flight mode" could help you out in this scenario.

Not really. It is possible to have flight mode on and be on Wi-Fi simultaneously, which would trigger unwanted syncing. Do you think you could implement the ethernet condition?

mikulik86 avatar Jul 26 '22 18:07 mikulik86

Yes, I wrote how it should be done above. And no, I'm not motivated to take my time here.

Catfriend1 avatar Jul 26 '22 19:07 Catfriend1

Unfortunately my extremely basic programming knowledge is not enough to know what exactly your instructions mean and how to do it. It's a pity, nonetheless thanks for this otherwise great fork.

mikulik86 avatar Jul 27 '22 15:07 mikulik86

@Catfriend1 I'm not interested in the feature here, but maybe you should give people the opportunity to sponsor you through GitHub Sponsor for nice badges, etc. That could rise your motivation, even maintaining this is effort.

martin-braun avatar Aug 13 '22 09:08 martin-braun

Would this also affect USB Tethering? In this case I am indeed interested in this feature.

martin-braun avatar Aug 13 '22 12:08 martin-braun

Maybe it can be achieved by third party automation tools, e.g. https://llamalab.com/automate/community/flows/41583

Catfriend1 avatar Nov 22 '22 22:11 Catfriend1

Maybe it can be achieved by third party automation tools, e.g. https://llamalab.com/automate/community/flows/41583

Thank you, this works nice for me. There is just one minor disadvantage: when controlled by Broadcast, force start/stop doesn't work. I suppose you wouldn't want to change it, would you?

mikulik86 avatar Feb 27 '23 21:02 mikulik86

I could look into it. Or you suggest a PR to make the buttons available when controlled by broadcast?

Catfriend1 avatar Mar 04 '23 20:03 Catfriend1

I would be glad if you could look into it and make your software even better. Thanks in advance.

mikulik86 avatar May 11 '23 17:05 mikulik86