windows-registry-node icon indicating copy to clipboard operation
windows-registry-node copied to clipboard

Update dependencies to napi versions to support Node 12

Open baparham opened this issue 5 years ago • 4 comments

I was looking for node 12 support and this seemed to work so I thought I would file a PR to see if you think it should go into the main repo.

baparham avatar Dec 10 '19 10:12 baparham

Seems like perhaps the CI file should also be updated to test against node 12. I can push another commit that will hopefully address that

baparham avatar Dec 10 '19 10:12 baparham

This (+ some unrelated code cleanup) was already proposed in https://github.com/CatalystCode/windows-registry-node/pull/62

zbynek avatar Dec 10 '19 17:12 zbynek

Thanks for engaging @zbynek - I can see that the other requests have been open a while, is it basically just held up with the maintainer(s)?

I also had the thought that perhaps a -napi fork of windows-registry should be published to the registry so that users might choose between the NAPI enabled version and this one depending on their node versions, but it seems like fixing this one and making it backward compatible with currently support node versions seems to make the most sense. Thoughts?

baparham avatar Dec 11 '19 08:12 baparham

If there's interest, I did end up writing an NAPI package native-reg after opening #62, but be warned it has an incompatible C-style API at the moment, so it's not drop-in. I'm happy to take requests, including API changes though.

simonbuchan avatar Jan 14 '20 08:01 simonbuchan