Replace get_the_title() used inside of markup

[stephen-czetty]

Replaced get_the_title() with the_title_attribute('echo=0').

This fixes an issue with the wp_typography plugin and titles that contain quotes and other special characters.

[jonathanbossenger]

@stephen-czetty thanks for the PR. As per the contributing guidelines please will you update the PR to be merged into the develop branch.

Thanks

[stephen-czetty]

Oh, oops, I read the guidelines but apparently too quickly! Made the change!

[jonathanbossenger]

@stephen-czetty Could I ask you elaborate on why this fix is necessary, if possible with an example we could use to replicate the problem.

I just want to make sure that the correct fix is being applied to our plugin.

Thanks

[stephen-czetty]

So the specific issue I ran into was an interaction with the wp-typography plugin and a podcast with a double-quote in the title. The typography adds markup to the quote, and it ends up in the title as displayed on the download link.

Screenshot attached.

[jonathanbossenger]

@stephen-czetty thanks, could I ask you to add some steps to replicate the issue, so I make sure I can do so on my side. Is there anything specific I need to configure in the wp-typography plugin?

[stephen-czetty]

I believe it is enabled by default, but under "Intelligent Character Replacement", make sure Smart Quotes are turned on. Then make sure there is a double-quote in the title of the podcast.

[jonathanbossenger]

Thanks, will work on reviewing it this week.