Stefano Gottardo

huge works IMO i think that here most of methods in UnicodeUtils and relative parts can take performance improvements by using `std::stringview` / `std::wstringview` in methods arguments instead of use...

what i mean with the use of std::string_view / std::wstring_view is that will optimize the performace because each time when you use std::string you are creating a new object and...

where you are using `std::vector` in the return value of `UnicodeUtils::Split` ? if so, this is wrong, string_view dont store data in memory it is just a reference to original...

only in some cases the subtitle engine have the ability to understand where the black bands are depends on how the video has been encoded since many people complained about...

ofc implicitly i also meant cropping case but doing so is not so simple, the engine is entirely changed from kodi 19 pointing out variable names does not change anything...

> Then found this: > > { // We should have a re-encoded/cropped (removed black bars) video source. // Then we cannot align to video otherwise the subtitles will be...

kodi 20 has differents behaviour of subtitle position setting than kodi 19, just for the sake of clarity, current meaning in Kodi 20 of position setting: `Bottom of Video` ->...

so if i understand correctly, you would like to do: `Bottom of Video` -> restored as Kodi 19 behaviour add new `Bottom of Screen` -> to kept the current `Bottom...

building and debug is not something that can be explained is two words, if you like to learn there are documentation: https://github.com/xbmc/xbmc/tree/master/docs guidelines, and doc for each operative system if...

@enen92 after asked to libass i understand how to do, this is a test: https://github.com/CastagnaIT/xbmc/commit/250d1de81546256e5db6aa7682a40c27a6305493 (to replicate it, change vertical margin to 0, and set "Position on screen" to "bottom...