pg_search icon indicating copy to clipboard operation
pg_search copied to clipboard

moved some column serializing logic to column_serializer and foreign_column_serializer

Open faucct opened this issue 8 years ago • 9 comments

Hello, people have had trouble searching by hstore columns, so I have split the serialization of column to sql into two separate classes, so you could pass your own column implementations to pg_search_scope and they will be serialized correctly, for example hstore column which I have already implemented.

faucct avatar Oct 29 '15 07:10 faucct

Would be nice to also have the README reflect how to use this as well.

key88sf avatar Dec 15 '15 15:12 key88sf

Super!

dapi avatar Apr 21 '16 19:04 dapi

To search for date:

  • loop on locales, and for each local store day_name, month_name, year (or any other format)
  • use array to save those localizations

Any plan on merging this ?

obsidienne avatar May 13 '16 14:05 obsidienne

Hi, I haven't had a lot of time to review pull requests lately, so sorry for the delayed response.

Overall I think this looks good. It's definitely one of the higher-quality pull requests I've received! So I want to merge it soon.

It would be better if we could accept arbitrary expressions instead of "Column" objects, but I think that's a larger refactor for later.

If someone can take a stab at documenting this feature in the README, I will merge it. And if someone could take a stab at a better syntax, I'd be very happy.

nertzy avatar May 28 '16 00:05 nertzy

Hello, @nertzy, I was thinking about handling 'description->en' strings as those columns, I could implement that this weekend.

faucct avatar May 28 '16 07:05 faucct

Hello, I have finally came to finish this one, can this be merged? The tests are broken for jdbc, but so they are in master.

faucct avatar Nov 26 '16 07:11 faucct

When will this be merged?

alecguintu avatar Mar 02 '17 03:03 alecguintu

@nertzy this feature would be great to include in your gem. Is it still the case you are simply waiting for the pull request to be amended with some instructions in the README? If so I would be happy to make my own pull request with that.

mzagaja avatar Jan 06 '18 22:01 mzagaja

@nertzy thanks for the great gem :) When are you planning to merge the functionality, which allows to search in jsonb? We are thinking to use it :)

ukiro-toptal avatar Jan 30 '19 11:01 ukiro-toptal