pg_search
pg_search copied to clipboard
moved some column serializing logic to column_serializer and foreign_column_serializer
Hello, people have had trouble searching by hstore columns, so I have split the serialization of column to sql into two separate classes, so you could pass your own column implementations to pg_search_scope
and they will be serialized correctly, for example hstore column which I have already implemented.
Would be nice to also have the README reflect how to use this as well.
Super!
To search for date:
- loop on locales, and for each local store day_name, month_name, year (or any other format)
- use array to save those localizations
Any plan on merging this ?
Hi, I haven't had a lot of time to review pull requests lately, so sorry for the delayed response.
Overall I think this looks good. It's definitely one of the higher-quality pull requests I've received! So I want to merge it soon.
It would be better if we could accept arbitrary expressions instead of "Column" objects, but I think that's a larger refactor for later.
If someone can take a stab at documenting this feature in the README, I will merge it. And if someone could take a stab at a better syntax, I'd be very happy.
Hello, @nertzy, I was thinking about handling 'description->en'
strings as those columns, I could implement that this weekend.
Hello, I have finally came to finish this one, can this be merged? The tests are broken for jdbc, but so they are in master.
When will this be merged?
@nertzy this feature would be great to include in your gem. Is it still the case you are simply waiting for the pull request to be amended with some instructions in the README? If so I would be happy to make my own pull request with that.
@nertzy thanks for the great gem :) When are you planning to merge the functionality, which allows to search in jsonb? We are thinking to use it :)