Automated-Fact-Checking-Resources icon indicating copy to clipboard operation
Automated-Fact-Checking-Resources copied to clipboard

Published 20 hours ago • verified publisher icon Cartus

Bumped Serilog.Sinks.PeriodicBatching to 3.1.0

Open vlm--- opened this issue 2 years ago • 2 comments

To ensure compatibility with other updated sinks (especially Serilog.Sinks.Seq)

vlm--- avatar Sep 28 '22 06:09 vlm---

Hi @vlm---!

It requires a bit of a code change in https://github.com/serilog-mssql/serilog-sinks-mssqlserver/blob/dev/src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/MSSqlServerSink.cs if you update the PeriodicBatching dependency because the interface has changed.

I already planned to update it but first I need to get PR #418 merged and fix the moderate vulnerability from #417 before I would be able to do this.

But if you have time to update the code to the new IBatchedLogEventSink within this PR, we would appreciate it.

ckadluba avatar Sep 28 '22 08:09 ckadluba

I’ve thought that too with the version 3.0.0, but in 3.1.0 the inheritance interface was brought back. Anyway, I’ll try to look more closely on this over the weekend.

vlm--- avatar Sep 28 '22 09:09 vlm---

I think it's good to go, all tests pass, every sample app works. MSSqlServerSink already implements IBatchedLogEventSink and not using old inheritance model and in the PeriodicBatchingSinkFactory, there is only one not used setting in PeriodicBatchingSinkOptions: QueueLimit, but it has reasonable default value.

vlm--- avatar Oct 03 '22 07:10 vlm---

Thank you very much! :)

ckadluba avatar Oct 03 '22 07:10 ckadluba