cartoframes icon indicating copy to clipboard operation
cartoframes copied to clipboard

Wrongly instantiated Map doesn't fail

Open josemazo opened this issue 5 years ago • 3 comments

I found this bug when I tried to create a map with two layers, ignoring that the first parameter, layers should be a list, and I passed the second layer as the basemap: Map(Layer(gdf), Layer(iso_gdf)). The result is that it doesn't say anything, not even an error, and the widget is empyt.

image

josemazo avatar Jan 16 '20 10:01 josemazo

You need to provide a list of Layers to the Map.

Map([Layer, Layer])

However, we should add some checks to validate the input parameters.

Jesus89 avatar Jan 16 '20 10:01 Jesus89

Yes, taking a not so quick look to the docs I got it, hehe.

josemazo avatar Jan 16 '20 11:01 josemazo

https://app.clubhouse.io/cartoteam/story/93708/add-params-check-on-every-function-class

Jesus89 avatar Jul 20 '20 06:07 Jesus89