changes in carto references

[matallo]

updated references in order to be able to support dot-properties in carto parser of CartoDB/cartodb

• added a new mapnik-reference from https://github.com/mapnik/mapnik-reference/blob/gh-pages/3.0.6/reference.json

I had to add it as a checked in file, instead of add a new dependency. I tried so, but had a hard time requiring the last version. It seems to work this way though.

• added torque-reference from https://github.com/CartoDB/torque-reference/blob/master/1.0.0/reference.json

it seems to have some property missing (such marker-width), I'll open a new issue for this, but generally this is the reference that should be used for any torque-related stuff

• renamed current torque-reference, to fallback-reference, which will be used as a last resort before throwing any error, as currently is a mishmash of mapnik and torque properties, eventually this reference should be removed and use either mapnik or torque-reference

note that mapnik-reference is 3.0.6 now (torque being 1.0.0) and this has consequences on how the cartocss is processed and the transformations applied, I think I'll have to talk to @dgaubert before any further discussion to merge this

thank you very much @rochoa for assisting me to corner the require mapnik reference issue

[dgaubert]

I'll create a tiler's branch pointing to this PR to check if everything goes smooth.

[rochoa]

I'll create a tiler's branch pointing to this PR to check if everything goes smooth.

@dgaubert, what do you plan to do? We don't need to fallback as we just use the torque-reference https://github.com/CartoDB/carto/blob/f4a2605a231ef96046075a396670a6fdf89fc756/lib/carto/torque-reference.js within the torque factory/renderer at Windshaft level. IIRC, the carto dependency we have in grainstore uses the mapnik-reference without any of our patches in torque-reference.

[matallo]

@dgaubert @rochoa just tell me if I can help or what I need to do next for this ^

[dgaubert]

@rochoa, If I understood correctly from the point of view of engine, we are not affected by this change, even if we update it to the further release in grainstore, right?

[AbelVM]

Hey mates, any news on this PR?

[xavijam]

Hey guys, I'm planning to merge this when possible. Anything I should take care/aware of?

[matallo]

wohoo