Carthage icon indicating copy to clipboard operation
Carthage copied to clipboard

.version file is not created for the current project with --no-skip-current

Open tmspzz opened this issue 7 years ago • 6 comments

  • carthage install method: [ ] .pkg, [ ] homebrew, [ ] source
  • which carthage: /usr/local/bin/carthage
  • carthage version: 0.31.2
  • xcodebuild -version: Build version 9F1027a
  • Are you using --no-build? No
  • Are you using --no-use-binaries? No
  • Are you using --use-submodules? No
  • Are you using --cache-builds? Yes
  • Are you using --new-resolver? Yes

Cartfile n/a Carthage Output n/a

Actual outcome

When running carthage build --no-skip-current .version files are generated for the dependencies but not for the current project

Expected outcome .version file is generated for the current project

Implementation suggestion

To extract the version all that needs to be done is:

git describe --exact-match `git rev-parse HEAD`

In case of no match just take the HEAD commitish

tmspzz avatar Nov 01 '18 21:11 tmspzz

Would appreciate if anyone could give their opinion @mdiep @ikesyo @jdhealy 👍

tmspzz avatar Nov 01 '18 21:11 tmspzz

Sounds like a reasonable thing to support. 👍

mdiep avatar Nov 01 '18 23:11 mdiep

Looks like this is dupe of #1846🙃

ikesyo avatar Nov 02 '18 00:11 ikesyo

2 birds with one stone. Off I go!

tmspzz avatar Nov 02 '18 14:11 tmspzz

@blender could you tell me what the status is of this ticket? The work seems to have been merged and I've been trying to test it out on the latest release but it does not seem to create the version file for me.

My setup:

  • carthage install method: [ ] .pkg, [x] homebrew, [ ] source
  • which carthage: /usr/local/bin/carthage
  • carthage version: 0.32.0
  • xcodebuild -version: N/A
  • Are you using --no-build? No
  • Are you using --no-use-binaries? No
  • Are you using --use-submodules? No
  • Are you using --cache-builds? Yes
  • Are you using --new-resolver? No

Cartfile n/a Carthage Output n/a

Steps

  • git clone https://github.com/ReactiveX/RxSwift.git

Actual outcome

  • When running carthage build --no-skip-current --platform iOS --cache-build the Carthage/Build/ directory is created but the content of it shows no version file. I only see the iOS sub-directory with the content of the RxSwift artefacts. Where should one be able to locate the version?
  • I noticed in the original ticket that --new-resolver is set to Yes but carthage build does not allow this flag as input and I'd also not expect it to resolve when I invoke this command unless I misunderstand.

willemfrishert avatar Feb 15 '19 18:02 willemfrishert

The work is merged but the release doesn't include it. You have to build carthage from HEAD.

tmspzz avatar Feb 16 '19 16:02 tmspzz