Tribo icon indicating copy to clipboard operation
Tribo copied to clipboard

Remove contextual menu when right clicking on non-post rows in the posts view.

Open Tanner opened this issue 12 years ago • 3 comments

The actual cause of the crash is when "Edit Post" is clicked. However, none of the menu items apply to an empty row, thus don't bother showing the menu.

No further code added other than making TBPostsViewController a NSMenuDelegate and handling menuNeedsUpdate.

I'm unsure if hiding all the items is the "correct" solution, but it works.

Tanner avatar Sep 05 '13 03:09 Tanner

This looks good, but I'd appreciate it if you would remove the extra whitespace in the method you added. See my note on your other recent PR for details.

CarterA avatar Sep 05 '13 17:09 CarterA

No problemo! I removed some whitespace. I am unsure if the coding style for single line conditionals/loops in relation for braces (same line, separate line, none if only one line, etc…). Let me know what style you would like and I can make the appropriate changes (if any).

Tanner avatar Sep 05 '13 17:09 Tanner

Sounds like it's time for @CarterA to write a coding style guide! Too bad he's not the kind of person who would enjoy writing a coding style guide.

...Wait.

GeorgeWS avatar Sep 06 '13 16:09 GeorgeWS