roslibrust icon indicating copy to clipboard operation
roslibrust copied to clipboard

Call unregisterPublisher on rosmaster RPC API when last Publisher handle is destroyed

Open ssnover opened this issue 2 years ago • 2 comments

rosmaster may assume this when the node destructs, but would be good and proper to call this to unregister the publisher.

ssnover avatar Sep 01 '23 17:09 ssnover

Would be interested in traffic snooping on a ros1 cpp node and ros1 python node and seeing what their behavior is.

While it might be "proper" to unregister. I think "best" is to copy what the "standard" clients do as closely as possible.

My money is on different behavior between the two of them...

Carter12s avatar Sep 01 '23 18:09 Carter12s

Can't wait to rewrite rosmaster so that it's easier to capture existing client behavior 😁

ssnover avatar Sep 01 '23 19:09 ssnover