Dr. Carsten Leue
Dr. Carsten Leue
This is probably the same as https://github.com/microsoft/vscode-remote-release/issues/6693 so we can join forces.
Hi @MainRo , thanks for pointing out the glitch in the context manager. Still I think it's not working as desired. My updated code is: ```python from typing import Iterator...
> The reference to the generator is kept as long as obs exists. I think that makes sense because - as you mention - you can re-subscribe to the source...
What about the life-cycle handling if the iterable is actually a generator? The generator features a `close` method (https://docs.python.org/3/reference/expressions.html#generator.close), wouldn't we expect this method to be invoked when the observable...
I have implemented an idea for an observable factory that takes the life cycle of iterables into account. It works for regular iterables, generators and their asyncio equivalents. https://github.com/Carsten-Leue/UtilsRxPY I...
> `MY_VAR` is neither function nor class and it doesn't have a PEP 224 variable docstring, so the branch skips it. I guess we might amend the branch to check...
> It is. But that's in the module _internal, I suppose, not in the module where __all__ is defined and MY_VAR exported ... True, but the same is true for...
> the signature of my_function shows the internal type name not the public one (it shows def my_function (iface: pdoc_test._internal.interface.MyInterface) ‑> str) instead of def my_function(iface: pdoc_test.MyInterface) ‑> str Duplicate...
> Type strings in docstrings are not modified, just queried, thus making MyInterface resolve to the available module-local definition. I do not fully understand this comment. `MyInterface` defined in `pdoc_test\_internal\sample.py`...
Thanks for having a look. Indeed there is a difference between the output for 3.6 and 3.7+. I generated my sample for 3.6, 3.7 and 3.8 for testing (https://github.com/Carsten-Leue/pdoc-test/blob/master/doc3.6/pdoc_test/index.html, https://github.com/Carsten-Leue/pdoc-test/blob/master/doc3.7/pdoc_test/index.html...