Carlos Roca Zaragoza

Results 46 comments of Carlos Roca Zaragoza

The steps are: ``` $ git clone https://github.com/OCA/$repo -b 17.0 $ cd $repo $ git checkout -b 17.0-mig-$module origin/17.0 $ git format-patch --keep-subject --stdout origin/17.0..origin/16.0 -- $module | git am...

And please avoid multiples commits for the migration process to avoid noice, your commits on the migration should be 2: - `[IMP] $module: pre-commit auto fixes` - `[MIG] $module: Migration...

Makes sense. Can you please add in the commit a brief explanation and the steps to reproduce the problem?

Right now, I don't know how this could be faced... But I know that we have customers who are using the assortments excluding products and we cannot assume this change......

The real problem of this is that we are taking all assortment domain at this point: https://github.com/OCA/sale-workflow/pull/3135/commits/7e8b7a484f85ed4fb4be881b95ac8ea9dc4f921c#diff-d857107550de88517b0f4cb32ae7770a25a630dc254b97191e7f71f262183089R36 Since we don't know what type of assortment is involved I think the...

4 sure, what I mean is that the excluded domain needs to be set with AND because it is restrictive, an excluded product discards any posible included product

That var is defined in line 29. I added comments explaining why need to redefine the list.

Added changes to make the button +1 faster. With these changes, what we do is to store the changes to be made while pressing the +1 button. Each time the...

@yajo I believe this should resolve this issue :smile: https://github.com/OCA/sale-workflow/issues/2842