Carl Smith

Results 75 comments of Carl Smith

Hey, this sounds like a good idea. My only concern would be that it could be quite tedious to define a function to handle all the different possible options for...

> It’d be even better to work this by providing a JSON Schema instead of manual definitions. That way, it’d address @CarlosNZ’s concern about handling complex data structures and also...

> I'm having trouble with the new key becoming NULL value when I add it. I'm imitating the onUpdate validation in the demo source code. But I can't add a...

@acidMyke -- this will be available in v1.25.0 -- look for the `newKeyOptions` prop. Should be out within a few days.

Done in #183 and released in [v1.25.0](https://www.npmjs.com/package/json-edit-react/v/1.25.0)

Well yeah, if it's a massive data set, the render tree is going to be pretty large/slow. There is one performance improvement I've added that you can take advantage of,...

Closing, as this doesn't seem like an actual problem. It's behaving as expected for what it is, as far as I can tell.

Hey, thanks for your comments. I hadn't really planned to do that. I'd be happy to export a different "Viewer" component, but that would just be a wrapper around the...

How about just a single `viewer` prop, which would disable all editing capability, so syntax would be: ```js ``` It wouldn't really help with the bundle size though, as it...

Okay, thanks for the heads-up, I'll fix this next week (unless someone else wants to make a PR)