Carlo Lucibello

Results 494 comments of Carlo Lucibello

Can't we trust users to use this in a safe way? We do it already for `rand!`.

I don't see a general solution for mutating functions violating implicit assumptions made by other rrules. Giving up entirely on them is a bit annoying, forces users into awkward alternative...

no idea why Zygote is failing

> Should this be here or in Zygote? i.e. is this a mathematical property of `copy` or something more specific? I would say it is a convention of the language,...

> Looks like Zygote is dropping gradients, specifically: this should be fixed on zygote master

> This PR should probably provide appropriate implementations for `rowtable`, `columntable`, `dictrowtable`, `dictcolumntable`, `table` as these are defined in Tables.jl (an additional benefit of doing this will be that package...

Done! Can you unlock CI?

good to go?

`Tables.subset` is a reasonable choice, fine for me

two very minor comments about the current state of documentation: - there is no search box (fixed in the revamp) - julia code highlighting is very faint