GraphNeuralNetworks.jl icon indicating copy to clipboard operation
GraphNeuralNetworks.jl copied to clipboard

GlobalConcatPool

Open casper2002casper opened this issue 3 years ago • 4 comments

Concatenates global features to the node features, is used to integrate global properties into the output of the nodes.

casper2002casper avatar Apr 15 '22 15:04 casper2002casper

Codecov Report

Merging #159 (866e416) into master (eb43bc9) will decrease coverage by 0.00%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   85.45%   85.44%   -0.01%     
==========================================
  Files          14       14              
  Lines        1299     1305       +6     
==========================================
+ Hits         1110     1115       +5     
- Misses        189      190       +1     
Impacted Files Coverage Δ
src/layers/pool.jl 93.54% <83.33%> (-2.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb43bc9...866e416. Read the comment docs.

codecov[bot] avatar Apr 15 '22 15:04 codecov[bot]

Nice addition, thanks. Needs tests and a few words explaining the behavior in the docstring.

CarloLucibello avatar Apr 15 '22 18:04 CarloLucibello

I changed it a bit, so any pooling layer can be used. Do you agree with this change? If so I'll add some documentation

casper2002casper avatar Apr 16 '22 10:04 casper2002casper

The test uses a GlobalPool layer, is this OK as it happens after the GlobalPool test, or should the test be fully isolated?

casper2002casper avatar Apr 16 '22 11:04 casper2002casper